TaskConfig: Add option for file_limit to set RLIMIT_NOFILE
#180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
containerd/containerd.go
Outdated
| @@ -342,6 +380,7 @@ func (d *Driver) createContainer(containerConfig *ContainerConfig, config *TaskC | |||
| containerd.WithRuntime(d.config.ContainerdRuntime, nil), | |||
| containerd.WithNewSnapshot(containerConfig.ContainerSnapshotName, containerConfig.Image), | |||
| containerd.WithNewSpec(opts...), | |||
| withFileLimit(uint64(config.FileLimit)), | |||
There was a problem hiding this comment.
Instead of unmarshalling just-built spec back, I'd suggest setting rlimit by appending your function to opts
There was a problem hiding this comment.
Thanks for pointing that out, I had to read a load of source code to find the right knobs to twist for this and that was something I missed. New revision just pushed up and verified in my test system!
sundbry
force-pushed
the
file-limit
branch
2 times, most recently
from
eea3c06 to
eb2daff
Compare
slonopotamus
approved these changes
May 11, 2024
Depending on the workload, the default resource limit (ulimit) for the max number of file descriptors per process may need to be raised, such as for database servers. Add a `file_limit` option to the task config which will allow the limit to be set per task. Signed-off-by: Ryan Sundberg <[email protected]>
|
@slonopotamus Please re-approve when you get a chance, I had to rebase the branch. Thanks! |
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
I have read the CLA Document and I hereby sign the CLA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the workload, the default resource limit (ulimit) for the max number of file descriptors per process may need to be raised, such as for database servers. Add a
file_limitoption to the task config which will allow the limit to be set per task.